Bump copyright year to current release year #75
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While looking through the README I noticed that the copyright year didn't match the year of the most recent release. This commit updates the values to match each other.
|
IMHO the copyright year is fine left at the starting year, so it doesn't need to be adjusted every year, but others may disagree. |
Yes, I think that's the most appropriate option here. |
oalders
requested changes
Jan 5, 2022
| @@ -3,7 +3,7 @@ author = Gisle Aas <gisle@activestate.com> | |||
| license = Perl_5 | |||
| main_module = lib/Net/HTTP.pm | |||
| copyright_holder = Gisle Aas | |||
| copyright_year = 2001-2017 | |||
| copyright_year = 2001-2021 | |||
There was a problem hiding this comment.
I think this PR could consist of just a change to this file. The others will be generated on dzil release. I would suggest copyright_year = 2001 so that we don't need to keep the range up to date annually.
|
Thanks for pointing this out, @paultcochrane . I've fixed it via 83119b8 |
|
Thanks for handling this @oalders! My apologies for not having replied sooner; my tuits outside of work have been very limited recently. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While looking through the README I noticed that the copyright year
didn't match the year of the most recent release. This commit updates
the values to match each other.
This PR is submitted in the hope that it is useful. If you want anything changed, please just let me know and I'm more than happy to update it and resubmit as necessary.
One thing that I was wondering: is the copyright holder still correct? Is Giles Aas still the copyright hoder, or should this be extended or changed in some way?