Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dependency on the logger gem which will be removed in Ruby 3.5 #397

Closed
Earlopain opened this issue Jun 5, 2024 · 2 comments
Closed

Dependency on the logger gem which will be removed in Ruby 3.5 #397

Earlopain opened this issue Jun 5, 2024 · 2 comments
Labels
bug

Comments

@Earlopain
Copy link
Contributor

Same deal as with all the other gems that happened in the last few years: In Ruby 3.4 a warning will be emitted, and in 3.5 an error will be raised. ruby/ruby@d7e558e

ruby-vips/lib/vips.rb

Line 8 in 74c20e6

require "logger"

It must probably be added to the gemspec.
@Earlopain Earlopain added the bug label Jun 5, 2024
jcupitt added a commit that referenced this issue Jun 5, 2024
@jcupitt
add logger to the gemspec
c1a05c2 
Since logger will be unbundled in ruby 3.5.

Thanks Earlopain

See #397
@jcupitt
Copy link
Member

jcupitt commented Jun 5, 2024

Hi @Earlopain, thanks for pointing this out. I've added logger to the gemspec.

@jcupitt jcupitt closed this as completed Jun 5, 2024
@Earlopain
Copy link
Contributor Author

That was quick, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jcupitt @Earlopain