Skip to content

Eventpool draft #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Eventpool draft #2

wants to merge 1 commit into from

Conversation

CurlyMoo
Copy link

@CurlyMoo CurlyMoo commented Jan 4, 2018

No description provided.

@CurlyMoo
Copy link
Author

CurlyMoo commented Jan 4, 2018

I will start with the first libuv-extra. My basic observer pattern in C based on libuv. In reality what i call eventpool contains a lot more code. I've also added a socket non-blocking IO abstraction in it in pilight based on uv_poll_t that allows me to natively use SSL with libuv, but i want to focus on this functionality first.

I've also started with this codebase, because all my other socket modules depend on that extended eventpool.

And as you will read, naming is hell for programmers, so probably we can will a great deal there as well 😄

Also, i'm fully ready for that discussion!

@CurlyMoo
Copy link
Author

So, any comments on this first attempt?

@bnoordhuis
Copy link
Member

Hi, and sorry for the delay. I only looked at this briefly (also because the idea is that this repo is only lightly reviewed by libuv maintainers) but what stands out to me is this:

  1. The style should preferably follow the main libuv repo. Not a blocker, just a good thing.

  2. I don't think we'd accept code that's under a different license than libuv itself (MPL vs MIT.)

@CurlyMoo
Copy link
Author

also because the idea is that this repo is only lightly reviewed by libuv maintainers

We've discussed that we would use a first PR to start the discussion. So let's discuss.

The style should preferably follow the main libuv repo. Not a blocker, just a good thing.

First conclusion from the discussion:

  1. The CONTRIBUTING.md should be copied from libuv to this repository.

I don't think we'd accept code that's under a different license than libuv itself (MPL vs MIT.)

That's clearly something i want to discuss more, because i don't like BSD (type) licenses and i don't like GPL type licenses either for the obvious reasons.

@CurlyMoo
Copy link
Author

Any interest in actually starting a discussion here or else i will withdraw my PR.

@CurlyMoo CurlyMoo closed this Jul 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants