Repository navigation
Ported code from SetupApi to CfgMgr32 - #362
Merged
Merged
Conversation
Windows operates natively in UTF-16 (WCHAR) so do we too.
DJm00n
force-pushed
the
remove_setup_api
branch
from
December 23, 2021 13:05
7c95075 to
c6be873
Compare
Youw
reviewed
Dec 24, 2021
Youw
left a comment
Youw
left a comment
Member
There was a problem hiding this comment.
Once you've removed dependency on SetupAPI - we should remove link dependency on it too: from CMakeLists, autotools and vsproj files
Member
|
This is nice refactoring, thanks. |
DJm00n
force-pushed
the
remove_setup_api
branch
2 times, most recently
from
December 28, 2021 18:24
9b7a293 to
0eea360
Compare
Youw
reviewed
Dec 29, 2021
Youw
reviewed
Dec 29, 2021
Youw
left a comment
Youw
left a comment
Member
There was a problem hiding this comment.
Remove all of the link dependencies on cfgmgr32 and hid from all of build scripts.
DJm00n
force-pushed
the
remove_setup_api
branch
from
January 6, 2022 15:53
0eea360 to
558d337
Compare
Youw
reviewed
Jan 8, 2022
Youw
left a comment
Youw
left a comment
Member
There was a problem hiding this comment.
except for the potential leak - looks good
Youw
approved these changes
Jan 9, 2022
|
A little curious why porting SetupApi to CfgMgr32?
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.