-
Notifications
You must be signed in to change notification settings - Fork 397
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
implement hid_get_input_report for Linux hidraw backend #351
Conversation
I don't know if this actually works with Linux < 5.11, but at least it should build. |
b651dd0
to
0fca9f3
Compare
Looking closer at the commit that implemented this in Linux, simply defining the macro won't do anything in Linux < 5.11 without the other changes in that commit. So I changed this to keep the old dummy code that just returns an error for old versions of Linux. |
0fca9f3
to
8ca0e0f
Compare
The ifdef checks the Kernel at compile time and returns the error if it was compiled on a too old Kernel. |
I have not tested that. |
I suppose that could actually happen with Flatpak... I'll test what happens with a VM running an old kernel. |
Lets have the functionality compile regardless of the kernel version (e.g. if not defined HIDIOCGINPUT - define it); |
edad695
to
6bd5157
Compare
Okay I switched it back to the original implementation copying the definition from hidraw.h. |
98d9ae7
to
ed57e4d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good.
I'd like to check it locally with my device(s) befor having it merged.
ed57e4d
to
364f6a6
Compare
Have you had a chance to test this yet? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I finally had.
Everything looks perfect. Thanks!
Thanks. Do you have a plan when you will make the next release? |
The major (minor actually) release is not going to happen soon - nothing really done for that. |
A patch release soon with this fix would be good. |
Any further updates about a patch release? |
Thanks! I made a PR to update vcpkg. |
I also made a PR to update the Rust bindings. |
Fixes #259