hidapi.h: fix API prototype for gcc flag -Wstrict-prototypes - #207
Merged
Conversation
With gcc 10.2.0 and compile flag '-Wstrict-prototypes' the new
APIs in hidapi.h trigger a compile warning:
../hidapi/hidapi.h:481:32: warning: function declaration isn’t a prototype [-Wstrict-prototypes]
481 | HID_API_EXPORT const struct hid_api_version* HID_API_CALL hid_version();
| ^~~~~~~~~~~~~~~
../hidapi/hidapi.h:491:3: warning: function declaration isn’t a prototype [-Wstrict-prototypes]
491 | HID_API_EXPORT const char* HID_API_CALL hid_version_str();
| ^~~~~~~~~~~~~~
To replicate:
./bootstrap
CFLAG=-Wstrict-prototypes ./configure
make
This is an issue for other projects, like OpenOCD, that use hidapi
and compile by default with '-Wstrict-prototypes -Werror'; the
warning above causes compile error while including hidapi.h.
Fix the prototypes by adding 'void' in the empty parameter list.
Signed-off-by: Antonio Borneo <borneo.antonio@gmail.com>
Youw
approved these changes
Nov 12, 2020
Collaborator
|
Can we enable all these warning flags in CI as well that we're fixing so we don't regress? |
Contributor
Author
|
Yes, it could be good to add more strict check during CI. |
Youw
pushed a commit
that referenced
this pull request
Nov 23, 2020
mcuee
added
build system/CI
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With gcc 10.2.0 and compile flag '-Wstrict-prototypes' the new
APIs in hidapi.h trigger a compile warning:
../hidapi/hidapi.h:481:32: warning: function declaration isn’t a prototype [-Wstrict-prototypes]
481 | HID_API_EXPORT const struct hid_api_version* HID_API_CALL hid_version();
| ^~~~~~~~~~~~~~~
../hidapi/hidapi.h:491:3: warning: function declaration isn’t a prototype [-Wstrict-prototypes]
491 | HID_API_EXPORT const char* HID_API_CALL hid_version_str();
| ^~~~~~~~~~~~~~
To replicate:
./bootstrap
CFLAG=-Wstrict-prototypes ./configure
make
This is an issue for other projects, like OpenOCD, that use hidapi
and compile by default with '-Wstrict-prototypes -Werror'; the
warning above causes compile error while including hidapi.h.
Fix the prototypes by adding 'void' in the empty parameter list.
Signed-off-by: Antonio Borneo borneo.antonio@gmail.com