Repository navigation
remove snprintf/strncat/strlen from fp_ident - #33
Merged
Merged
Conversation
levitte
approved these changes
Sep 16, 2024
fp_ident is the only place tomsfast math uses string manipulation functions when built as a library. This commit replaces them with safe, trivial functions for concatonating static strings and numbers together.
Signed-off-by: Steffen Jaeckel <s@jaeckel.eu>
* do error checking. * also print `SIZEOF_FP_DIGIT` and `DIGIT_SHIFT`. * cut static buffer in half, currently the output string is 183 chars on my machine, so it's still more than enough for all the other options. Signed-off-by: Steffen Jaeckel <s@jaeckel.eu>
sjaeckel
force-pushed
the
ryancdotorg/non_str_funcs
branch
from
September 21, 2024 12:59
0ca5ea3 to
1519aa1
Compare
Member
|
I took the liberty to force-push after incorporating some changes. I hope that's fine with you? :) |
levitte
approved these changes
Sep 23, 2024
levitte
left a comment
levitte
left a comment
Collaborator
There was a problem hiding this comment.
The sum total of changes look good to me
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fp_ident is the only place tomsfast math uses string manipulation functions when built as a library. This commit replaces them with safe, trivial functions for concatenating static strings and numbers together.
This is a smaller part of a patchset to allow tomsfastmath to be compiled without stdlib, e.g. for freestanding webassembly.