Skip to content

Rename bn_get_magxx -> bn_get_mag_uxx. Documentation updated too #325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 4, 2019
Merged

Rename bn_get_magxx -> bn_get_mag_uxx. Documentation updated too #325

merged 1 commit into from
Jul 4, 2019

Conversation

nijtmans
Copy link
Collaborator

@nijtmans nijtmans commented Jul 3, 2019

As suggested by @sjaeckel, renaming those functions helps to resolve the possible confusion about the unsigned return type.

@nijtmans nijtmans requested review from sjaeckel and minad July 3, 2019 12:47
@minad minad mentioned this pull request Jul 3, 2019
Merged
sjaeckel
sjaeckel approved these changes Jul 4, 2019
View reviewed changes
Copy link
Member

@sjaeckel sjaeckel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 thanks alot!

@sjaeckel sjaeckel merged commit 5190ae6 into develop Jul 4, 2019
@sjaeckel sjaeckel deleted the rename_mag_fn branch July 4, 2019 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@minad minad minad approved these changes

@sjaeckel sjaeckel sjaeckel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nijtmans @minad @sjaeckel