Skip to content

Deprecate macros (2) #226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 26, 2019
Merged

Deprecate macros (2) #226

merged 4 commits into from
Apr 26, 2019

Conversation

minad
Copy link
Member

@minad minad commented Apr 25, 2019

Compare with #223. I think this version is more reasonable.

@minad
Copy link
Member Author

minad commented Apr 25, 2019

@sjaeckel ok to merge this?

Copy link
Member

@sjaeckel sjaeckel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wanted to approve already yesterday... sorry

@sjaeckel sjaeckel merged commit 91d953e into develop Apr 26, 2019
@sjaeckel sjaeckel deleted the deprecate-macros2 branch April 26, 2019 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants