Skip to content

Proposal of changes to #160 #173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 6 commits into from
Closed

Proposal of changes to #160 #173

wants to merge 6 commits into from

Conversation

sjaeckel
Copy link
Member

@sjaeckel sjaeckel commented Mar 7, 2019

This is an update of #160 but I didn't know if that's really what we want, so I opened a separate PR

@czurnieden
Copy link
Contributor

Thanks for the clean-up!

This is an update of #160 but I didn't know if that's really what we want

Assuming "that" means #160 : it's not much work to keep it "mergeable" (as long as I don't eff it up again ;-) ) so that the decision can be restricted to "moving it into the main version or not". It helps to avoid arguments like "Yeah, would like it but there is a lot of work to do before we can include it!", which are rarely helpful.

run make astyle

Was sure I told my little editor to run it before saving? Ah, no it isn't able to do it, run a program before saving that is, my misunderstanding, sorry.

@sjaeckel
Copy link
Member Author

sjaeckel commented Mar 7, 2019

Assuming "that" means #160

hrhr, "that" meaning "the changes in this PR" :-D

especially the stuff regarding Valgrind

Was sure I told my little editor to run it before saving

we could add a pre-commit hook!?

In general: if you think this PR is okay and doesn't need any further changes, simply apply the patches to your branch and we can close this

@sjaeckel
Copy link
Member Author

sjaeckel commented Mar 7, 2019

You can install the hook with make install_hooks

If you try to commit it will run make astyle and if that had to format something it will stop the commit so you can fix it up

@czurnieden
Copy link
Contributor

we could add a pre-commit hook!?

Yes, that is a nice one, thanks!

if you think this PR is okay and doesn't need any further changes, simply apply the patches to your branch

Done, together with a word or two regarding the x87 warning macro in the documentation.
I think that was all by now.

@sjaeckel sjaeckel closed this Mar 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants