gcc + __attribute__((deprecated))

[karel-m]

Building with gcc-3.4.5 fails with error:

tommath.h:234: error: wrong number of arguments specified for `deprecated' attribute

It looks like gcc 3.x does support:

__attribute__((deprecated))

but not:

__attribute__((deprecated("some message")))

[karel-m]

IMO __attribute__((deprecated("some message"))) is supported since gcc-4.5.0 see:

• https://gcc.gnu.org/onlinedocs/gcc-4.5.0/gcc/Function-Attributes.html (supported)
• https://gcc.gnu.org/onlinedocs/gcc-4.4.7/gcc/Function-Attributes.html (unsupported)

So perhaps:

- #if defined(__GNUC__) && (__GNUC__ * 100 + __GNUC_MINOR__ >= 301)
+ #if defined(__GNUC__) && (__GNUC__ * 100 + __GNUC_MINOR__ >= 405)

[karel-m]

Or more complicated:

- #if defined(__GNUC__) && (__GNUC__ * 100 + __GNUC_MINOR__ >= 301)
+ #if defined(__GNUC__) && (__GNUC__ * 100 + __GNUC_MINOR__ >= 405)
  #  define MP_DEPRECATED(x) __attribute__((deprecated("replaced by " #x)))
  #  define PRIVATE_MP_DEPRECATED_PRAGMA(s) _Pragma(#s)
  #  define MP_DEPRECATED_PRAGMA(s) PRIVATE_MP_DEPRECATED_PRAGMA(GCC warning s)
+ #elif defined(__GNUC__) && (__GNUC__ * 100 + __GNUC_MINOR__ >= 301)
+ #  define MP_DEPRECATED(x) __attribute__((deprecated))
+ #  define PRIVATE_MP_DEPRECATED_PRAGMA(s) _Pragma(#s)
+ #  define MP_DEPRECATED_PRAGMA(s) PRIVATE_MP_DEPRECATED_PRAGMA(GCC warning s)
  #elif defined(_MSC_VER) && _MSC_VER >= 1500
  #  define MP_DEPRECATED(x) __declspec(deprecated("replaced by " #x))
  #  define MP_DEPRECATED_PRAGMA(s) __pragma(message(s))
  #else
  #  define MP_DEPRECATED(s)
  #  define MP_DEPRECATED_PRAGMA(s)
  #endif

[minad]

@karel-m This has been fixed in 1eceaea in #262

[karel-m]

The #262 is not correct

[minad]

@karel-m What do you mean? Is not correct? #262 has not been merged yet, do you mean that?

[karel-m]

#if defined(__GNUC__) && __GNUC__ >= 4 is wrong and will cause a failure with e,g, gcc-4.4 see my research above.

[minad]

@karel-m Thank you. Fixed in #262

[karel-m]

Great, closing this one.