Skip to content

Fix PBES and OMAC flag scopes #687

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 23, 2025
Merged

Conversation

UnknownDK
Copy link
Contributor

pbes_properties and omac_state are gatekept by LTC_PBES and LTC_OMAC respectively. Therefore they should only be used within those scopes.

pbes_properties and omac_state are gatekept by LTC_PBES and LTC_OMAC
respectively. Therefore they should only be used within those scopes.
@UnknownDK
Copy link
Contributor Author

Fixes these errors with LTC_NOTHING.

 ~/r/libtomcrypt> make CFLAGS="-DLTC_NOTHING"                                                                                            2 develop
   * cc src/ciphers/aes/aes.o
In file included from src/ciphers/aes/aes.c:25:
./src/headers/tomcrypt_private.h:114:10: error: unknown type name ‘pbes_properties’
  114 |    const pbes_properties *data;
      |          ^~~~~~~~~~~~~~~
./src/headers/tomcrypt_private.h:182:19: error: unknown type name ‘omac_state’
  182 | int omac_vprocess(omac_state *omac, const unsigned char *in,  unsigned long inlen, va_list args);
      |                   ^~~~~~~~~~
make: *** [makefile:64: src/ciphers/aes/aes.o] Error 1

@UnknownDK
Copy link
Contributor Author

@sjaeckel is anything missing here?

@sjaeckel
Copy link
Member

Nope, sorry, I'll have a look later.

@sjaeckel sjaeckel merged commit 3905c28 into libtom:develop Apr 23, 2025
78 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants