Skip to content

pkcs_5_alg1 hangs if iterations is 0 #552

Description

@guidovranken

Prerequisites

Description

pkcs_5_alg1 hangs if iterations is 0. It would be better to return an error value in this case.

Steps to Reproduce

#include <tomcrypt.h>

#define CF_CHECK_EQ(expr, res) if ( (expr) != (res) ) { goto end; }
#define CF_CHECK_NE(expr, res) if ( (expr) == (res) ) { goto end; }

int main(void)
{
    const unsigned char password[8] = { 0 };
    const unsigned char salt[8] = { 0 };
    unsigned char out[8];
    unsigned long outLen = sizeof(out);

    CF_CHECK_NE(register_hash(&sha256_desc), -1);

    CF_CHECK_EQ(pkcs_5_alg1(
                password,
                sizeof(password),
                salt,
                0,
                find_hash("sha256"),
                out,
                &outLen), CRYPT_OK);
end:
    return 0;
}

Version

Latest develop branch checkout, Clang, Linux 64 bit.

Additional Information

N/A

Activity

added a commit that references this issue on Nov 8, 2020
a02983b
added a commit that references this issue on Dec 21, 2020
11978c1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions