This repository has been archived by the owner on Oct 18, 2023. It is now read-only.
hrana: add diagnostics for connections #729
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarinPostma
suggested changes
Oct 4, 2023
|
@psarna, can you rebase maybe? |
This commit adds a /v2/diagnostics endpoint which prints
various information about current hrana-over-http connections.
Draft, because the diagnostics are currently in a very debuggy
format, and I'm figuring out if we can make it more human-readable.
Still, they're enough to determine if something is holding a lock
via an abandoned hrana-over-http stream.
Example:
```
$ curl -s http://localhost:8080/v2/diagnostics | jq
[
"expired",
"expired",
"expired",
"expired",
"expired",
"(conn: Mutex { data: <locked> }, timeout_ms: 872, stolen: false)",
"(conn: Mutex { data: <locked> }, timeout_ms: 0, stolen: true)"
]
```
Co-authored-by: ad hoc <postma.marin@protonmail.com>
|
This PR should have absolutely 0 to do with with bottomless, and yet I see bottomless test failures, that always pass for me locally. Maybe we have some kind of regression, let me investigate |
|
Oh wait, now they failed for me locally too, good |
psarna
commented
Oct 5, 2023
| @@ -199,6 +201,9 @@ unsafe impl WalHook for ReplicationLoggerHook { | |||
| "Ignoring a checkpoint request weaker than TRUNCATE: {}", | |||
| emode | |||
| ); | |||
| if emode == SQLITE_CHECKPOINT_PASSIVE { | |||
| return SQLITE_OK; | |||
There was a problem hiding this comment.
oh wow, that's leftovers from my early tests, it should not be there at all
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds a
/v1/diagnosticsadmin endpoint which prints various information about current hrana-over-http connections.Draft, because the diagnostics are currently in a very debuggy format, and I'm figuring out if we can make it more human-readable. Still, they're enough to determine if something is holding a lock via an abandoned hrana-over-http stream.
Example: