Abstract sqld networking #650
Conversation
MarinPostma
force-pushed
the
refactor-generic-networking
branch
13 times, most recently
from
b76c2f1 to
cec7108
Compare
MarinPostma
force-pushed
the
refactor-generic-networking
branch
6 times, most recently
from
73a6d75 to
1a3cd5d
Compare
MarinPostma
force-pushed
the
refactor-generic-networking
branch
from
1a3cd5d to
d132025
Compare
MarinPostma
force-pushed
the
refactor-generic-networking
branch
from
d132025 to
797f9aa
Compare
| continue; | ||
| }; | ||
| let socket: Box<dyn Conn> = Box::new(conn); | ||
| let _: Result<_, _> = accept_tx.send(Accept { socket, peer_addr }).await; |
There was a problem hiding this comment.
Should we close the acceptor if the other end has disappeared?
There was a problem hiding this comment.
Which acceptor are you referring to?
sqld/src/http/mod.rs
Outdated
| pub auth: Arc<Auth>, | ||
| pub http_acceptor: Option<A>, | ||
| pub hrana_ws_acceptor: Option<A>, | ||
| pub namespaces: NamespaceStore<M>, | ||
| pub idle_shutdown_kicker: Option<IdleShutdownKicker>, | ||
| pub stats: Stats, | ||
| pub proxy_service: P, | ||
| pub replication_service: S, | ||
| pub disable_default_namespace: bool, | ||
| pub disable_namespaces: bool, | ||
| pub max_response_size: u64, | ||
| pub enable_console: bool, | ||
| pub self_url: Option<String>, | ||
| pub join_set: &'a mut JoinSet<anyhow::Result<()>>, |
There was a problem hiding this comment.
Is it possible to avoid all these pub? I think this just makes refactoring code later on really hard since these items leak pretty easily.
There was a problem hiding this comment.
What would you suggest?
| pub struct Server<C = HttpConnector, A = AddrIncoming> { | ||
| pub path: Arc<Path>, | ||
| pub db_config: DbConfig, | ||
| pub user_api_config: UserApiConfig<A>, |
There was a problem hiding this comment.
I think we should call it HttpServer (matches the mod) and RpcServer (like you have already). I think that reads the best.
There was a problem hiding this comment.
Idk, it's not only an HTTP server, if anything, it's a SqldServer, but since we're changing the name, I avoid including sqld into anything. Any other ideas?
MarinPostma
force-pushed
the
refactor-generic-networking
branch
from
86fc033 to
3166f30
Compare
|
@LucioFranco, merging this to move forward, I can address your points in followups if you want. |
This PR aims to abstract networking for sqld so that we can simulate it and start writing tests using turmoil for network simulation.
I took the opportunity to clean up the configuration process and remove useless stuff that accumulated with time.
The
--backendflag was removed because it is unused.The
netmodule contains network abstractions used throughout the crate.