Skip to content
This repository has been archived by the owner on Oct 18, 2023. It is now read-only.

Add last_insert_rowid to Hrana statement result #276

Merged
merged 1 commit into from
Mar 9, 2023
Merged

Add last_insert_rowid to Hrana statement result #276

merged 1 commit into from
Mar 9, 2023

Conversation

honzasp
Copy link
Contributor

@honzasp honzasp commented Mar 9, 2023

This information may be useful, and it's required to implement some client libraries (for example, to emulate the Node.js sqlite3 package).

@honzasp honzasp requested a review from MarinPostma March 9, 2023 11:59
@haaawk
Copy link
Collaborator

haaawk commented Mar 9, 2023

Golang driver needs that too

haaawk
haaawk approved these changes Mar 9, 2023
View reviewed changes
Copy link
Collaborator

@haaawk haaawk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@honzasp
Copy link
Contributor Author

honzasp commented Mar 9, 2023

bors merge

@bors
Copy link
Contributor

bors bot commented Mar 9, 2023

Build succeeded:

@bors bors bot merged commit 9c5ea9c into libsql:main Mar 9, 2023
@honzasp honzasp deleted the hrana-last-rowid branch March 10, 2023 07:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@haaawk haaawk haaawk approved these changes

@MarinPostma MarinPostma Awaiting requested review from MarinPostma

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@honzasp @haaawk