This repository was archived by the owner on Oct 18, 2023. It is now read-only.
primary idle shutdown#242
Merged
Merged
Conversation
haaawk
approved these changes
Feb 22, 2023
haaawk
left a comment
haaawk
left a comment
Contributor
There was a problem hiding this comment.
Amazing! Thanks a lot @MarinPostma
Contributor
|
I think we just need to fix clippy and we're good to go. Let's get this merged today and I can test it and enable it on Turso tomorrow. |
MarinPostma
force-pushed
the
primary-idle-shutdown
branch
from
37437c2 to
886d92b
Compare
Contributor
Author
|
bors merge |
Contributor
|
Build succeeded:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds idle shutdown to the primary by sharing the IdleShutdownService with the rpc server.
Whenever the primary does not receive any ping from replicas for some period AND doesn't get any requests, then it shuts down.