This repository was archived by the owner on Oct 18, 2023. It is now read-only.
python package check version #230
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarinPostma
force-pushed
the
python-check-version
branch
from
8ba59ba to
31e3a19
Compare
honzasp
suggested changes
Feb 17, 2023
| @@ -40,6 +70,9 @@ async def batch(self, stmts: List[_RawStmt]) -> List[ResultSet]: | |||
| async def close(self) -> None: | |||
| await self._session.close() | |||
|
|
|||
| def queries_url(self): | |||
There was a problem hiding this comment.
Ditto, it would be better to prefix the private method with _. Also, perhaps we should add the logic for switching between / and /queries here?
There was a problem hiding this comment.
yes this is a placeholder for switching the route, but the queries route is not yet merged, and this will be merged first
There was a problem hiding this comment.
In that case, perhaps we should merge this PR later? At this point, it's just a noop that introduces extra latency.
MarinPostma
force-pushed
the
python-check-version
branch
from
31e3a19 to
b571d56
Compare
MarinPostma
force-pushed
the
python-check-version
branch
from
b571d56 to
00e8786
Compare
MarinPostma
force-pushed
the
python-check-version
branch
from
00e8786 to
c9ebcb1
Compare
honzasp
approved these changes
Feb 17, 2023
|
bors merge |
|
Build succeeded:
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add version check to python package