-
Notifications
You must be signed in to change notification settings - Fork 12
Use a separate thread to update the display (#57) #58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
not sure if you're aware but it seems like the display doesn't get updated enough here, it gets quite noticeable with tunes that switch waveforms very fast like Jeroen Tel's which's weird considering the display updates every 16 or 20 ms, to correspond to 60 and 50 Hz··· and lowering that refresh rate just makes the screen flicker more while still not updating the information properly |
17d4c04 to
c68b777
Compare
|
Yeah, it seems like updates happen in bursts, have no clue why... |
674dd1c to
71a00d8
Compare
|
Oh wait, the problem is that the audio writes are blocking so there is no update to the emulation while buffers are played back. So we are still limited by the buffer size. If you try with -w you can see the display is very quick. |
|
yeah that's what i was guessing x) |
4ed9276 to
e9dd44a
Compare
f04f8da to
7abc1d6
Compare
|
hey, i decided to fiddle with this code on my fork and i got some promising results i'm still limited by the buffer size as well but at least making a new thread for refreshing the display gave it a more consistent refresh rate, so i'm already somewhere (i'm still using the old approach for the buffer size because of that, it would look really janky with the current one) apparently either that or EDIT: hmm just checked PulseAudio's Asynchronous API, maybe that could help as it's designed for threaded apps so here is a path we can take |
|
Currently reworking the playback logic, not sure if this is still useful. |
|
yeah that's what i thought |
No description provided.