Fix subclass overrides and initialization order #309
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Joseph-Edwards
commented
Aug 1, 2025
Comment on lines
+565
to
+571
| // TODO(0): Uncomment or remove | ||
| // thing.def(py::init<Thing const&>(), | ||
| // fmt::format(R"pbdoc( | ||
| // Construct from a {0} object. | ||
| // )pbdoc", | ||
| // doc_type) | ||
| // .c_str()); |
There was a problem hiding this comment.
Presently, because of how sims.py is setup, the only 1-parameter constructor for a Sims object takes a presentation. However, in libsemigroups we can construct from other Sims objects. Do we want to be able to do that here too?
If yes, we should uncomment the above function and adjust sims.p. If no, we should delete the above function.
There was a problem hiding this comment.
Note that this function hasn't always been here. I wrote it for this PR, but then commented it out when I saw how sims.py was setup.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does two things: