Conversation
|
I think all the functionality is there, I just have to finish adding the documentation. |
|
@james-d-mitchell I think your fork is behind since the tests are out of sync with main. Just merged in, everything should pass now. EDIT: Nevermind, hadn't seen that you modified transf. Will do a full review later. |
james-d-mitchell
force-pushed
the
bmat8
branch
from
15955b6 to
f29327f
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #48 +/- ##
=======================================
Coverage ? 56.69%
=======================================
Files ? 10
Lines ? 448
Branches ? 0
=======================================
Hits ? 254
Misses ? 194
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
james-d-mitchell
force-pushed
the
bmat8
branch
from
f29327f to
d94bd2c
Compare
|
I just need to add tests and this should be good to go (note everything is tested in the docs, so it's just a matter of extracting the code examples and putting them in a test file). |
|
@jswent Any idea why the docs are failing? |
james-d-mitchell
force-pushed
the
bmat8
branch
from
d94bd2c to
eada35e
Compare
not sure, haven't seen a segfault before. just tested on a throwaway PR and got the same result, which was passing before. will look into it later. |
|
@james-d-mitchell should be fixed, appears to be a problem with the latest version of julia so I pinned a stable version to the CI checks |
|
Thanks @jswent! |
james-d-mitchell
force-pushed
the
bmat8
branch
from
e55711d to
4a9d1d3
Compare
|
This is now good to go |
james-d-mitchell
force-pushed
the
bmat8
branch
from
4a9d1d3 to
9ef5e1c
Compare
james-d-mitchell
force-pushed
the
bmat8
branch
from
9ef5e1c to
f91e6d9
Compare
| type.method("multiply", [](BMat8 const& self, BMat8 const& that) { | ||
| return self * that; | ||
| }); | ||
| type.method("multiply", | ||
| [](BMat8 const& self, bool scalar) { return self * scalar; }); | ||
| type.method("multiply", [](BMat8& self, bool val) { return self * val; }); | ||
| type.method("multiply", [](bool val, BMat8& self) { return val * self; }); | ||
| type.method("multiply!", | ||
| [](BMat8& self, BMat8 const& that) { self *= that; }); | ||
| type.method("multiply!", [](BMat8& self, bool scalar) { self *= scalar; }); |
There was a problem hiding this comment.
CxxWrap overloads are unreliable, should be disambiguated
| end | ||
|
|
||
| Base.:(==)(x::BMat8, y::BMat8) = LibSemigroups.is_equal(x, y) | ||
| Base.:(<)(x::BMat8, y::BMat8) = LibSemigroups.is_less(x, y) |
There was a problem hiding this comment.
Base.isless needs to be defined as well for sort() to work
There was a problem hiding this comment.
is_less or isless?
There was a problem hiding this comment.
is_lessorisless?
Base.isless, source docs can be seen here
| function Base.getindex(x::BMat8, r::Int64, c::Int64)::Bool | ||
| return LibSemigroups.at(x, UInt(r - 1), UInt(c - 1)) | ||
| end | ||
|
|
||
| function Base.getindex(x::BMat8, r::Int64)::Vector{Bool} | ||
| return LibSemigroups.at(x, UInt(r - 1)) | ||
| end |
There was a problem hiding this comment.
these should be wrapped with @wrap_libsemigroups_call for error handling
|
|
||
| Returns the degree of a [`BMat8`](@ref). | ||
|
|
||
| This function returns the degree of `x` which is always returns `8`. |
There was a problem hiding this comment.
| This function returns the degree of `x` which is always returns `8`. | |
| This function returns the degree of `x` which always returns `8`. |
3 participants
No description provided.