voipchat: allow configuring server bind address from cli arguments #109
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
madebr
force-pushed
the
server-bind-address-from-arguments
branch
from
d755aca to
8706803
Compare
|
Is this patch waiting for something? (needs a rebase, btw.) |
madebr
force-pushed
the
server-bind-address-from-arguments
branch
from
8706803 to
b3cafc4
Compare
icculus
force-pushed
the
server-bind-address-from-arguments
branch
from
b3cafc4 to
ebc2260
Compare
icculus
force-pushed
the
server-bind-address-from-arguments
branch
from
ebc2260 to
fdbf6e6
Compare
|
This is rebased now and can merge once the builders are happy. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows you to bind the
voipchatserver to127.0.0.1or::1.This change is motivated by the following observations of current
voipchat:When running
voipchat --server, it was unclear to what socket the server was bound to.Also, the following combination failed for me:
server command:
./voipchat --serverclients command:
./voipchat localhostOnly after changing the client command to
./voipchat 127.0.0.1could I get working voip.This pr explicitly selects a binding address for the server, so it will never pass
NULLtoSDLNet_CreateDatagramSocketwhen creating a server.Perhaps #85 is related.