SDL_audiotypecvt.c: Fixed memory corruption when resampling S16 t F32

Wohlstand · icculus · commit ca010165770b · 2024-02-03T08:20:04.000-05:00
diff --git a/src/audio/SDL_audiotypecvt.c b/src/audio/SDL_audiotypecvt.c
@@ -125,7 +125,7 @@ static void SDLCALL SDL_Convert_U8_to_F32_Scalar(SDL_AudioCVT *cvt, SDL_AudioFor
 
 static void SDLCALL SDL_Convert_S16_to_F32_Scalar(SDL_AudioCVT *cvt, SDL_AudioFormat format)
 {
-    const int num_samples = cvt->len_cvt;
+    const int num_samples = cvt->len_cvt / sizeof(Sint16);
     const Sint16 *src = (const Sint16 *)cvt->buf;
     float *dst = (float *)cvt->buf;
     int i;

Original file line number	Diff line number	Diff line change
`@@ -125,7 +125,7 @@ static void SDLCALL SDL_Convert_U8_to_F32_Scalar(SDL_AudioCVT *cvt, SDL_AudioFor`
`125`	`125`
`126`	`126`	`static void SDLCALL SDL_Convert_S16_to_F32_Scalar(SDL_AudioCVT *cvt, SDL_AudioFormat format)`
`127`	`127`	`{`
`128`		`- const int num_samples = cvt->len_cvt;`
	`128`	`+ const int num_samples = cvt->len_cvt / sizeof(Sint16);`
`129`	`129`	`const Sint16 src = (const Sint16 )cvt->buf;`
`130`	`130`	`float dst = (float )cvt->buf;`
`131`	`131`	`int i;`