Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

android: Merge 8BitDo Pro 2 configs #1193

Merged
merged 6 commits into from
Sep 17, 2024
Merged

android: Merge 8BitDo Pro 2 configs #1193

merged 6 commits into from
Sep 17, 2024

Conversation

landfillbaby
Copy link
Contributor

@landfillbaby landfillbaby commented Sep 16, 2024 •
edited
Loading

not sure if i made a mistake back then, or if the controller firmware changed the axes somewhere between v1.05 and v3.04

either way this works fully and is ready for merge

@landfillbaby landfillbaby changed the title fix trigger axes in android/8BitDo_Pro2_updatedFW.cfg [READY] fix trigger axes in android/8BitDo_Pro2_updatedFW.cfg Sep 16, 2024
@landfillbaby landfillbaby changed the title [READY] fix trigger axes in android/8BitDo_Pro2_updatedFW.cfg [READY] android: fix trigger axes in 8BitDo_Pro2_updatedFW.cfg Sep 16, 2024
@landfillbaby
Copy link
Contributor Author

landfillbaby commented Sep 16, 2024 •
edited
Loading

ok so i messed around with firmware downgrades and it turns out the trigger axes should always have been 6 and 7.
then i realised it could be merged using libretro/RetroArch#16990.
hope i did it right! i don't have the dev build installed on my device for testing yet

unrelated: for some reason when the controller is in the default profile (no white lights) on android (D-input) mode, the left and right paddles act as BUTTON_Z (101) and BUTTON_C (98) respectively. however if the paddles are left as default on the customizable profiles they do nothing. weird.

@landfillbaby landfillbaby changed the title [READY] android: fix trigger axes in 8BitDo_Pro2_updatedFW.cfg [READY] android: merge the 3 PIDs of the 8BitDo Pro 2 into one config Sep 16, 2024
@landfillbaby
Copy link
Contributor Author

landfillbaby commented Sep 16, 2024 •
edited
Loading

ok apparently i did it wrong, if that's what ci failure means

@landfillbaby
Copy link
Contributor Author

landfillbaby commented Sep 17, 2024 •
edited
Loading

ok does it work now? do i need to do input_device_alt1/2 or input_device_display_name_alt1/2?

@landfillbaby
Copy link
Contributor Author

libretro/RetroArch#16990 (comment)

@landfillbaby
Copy link
Contributor Author

ok it's really ready now! unless you want me to add another alt that detects whether it's Bluetooth or USB on the new firmware using the prepending described within!

@RobLoach RobLoach changed the title [READY] android: merge the 3 PIDs of the 8BitDo Pro 2 into one config android: Merge 8BitDo Pro 2 configs Sep 17, 2024
@RobLoach RobLoach merged commit 09a100d into libretro:master Sep 17, 2024
1 check passed
@landfillbaby landfillbaby deleted the patch-2 branch September 17, 2024 05:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@landfillbaby @RobLoach