Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Palettes notifications are not synchronised with the currently selected palette (Linux / SDL1.2 / RGUI) #238

Open
schmurtzm opened this issue Oct 20, 2022 · 1 comment

Comments

@schmurtzm
Copy link

Description

Since this pull request : #204 , it is possible to switch between gambatte palettes via RetroPad L/R that's very nice and works well but when using RGUI on Miyoo Mini (a little linux handheld) each notification doesn't not override the previous one.
So if you change quickly 5 palettes you'll see previous palettes names on notifications and you don't know which is the current one. This little problem is very annoying to choose your palette.

One Retroarch for Windows the notifications toasters are not the same and each new palette notification override the previous one in the right way.

A little video to illustrate (I press 3 times R and 2 times L)

2022-10-20.23.23.550874.mp4

As you can see the notifications are late.

(I have hesitated to create this issue in Retroarch repo as the callback to enable cores to notify is in Retroarch I'm not very sure.)

Expected behavior

As on retroarch for Windows the new notifications for gambatte palettes should override the previous one.

Actual behavior

On RGUI, each notification is displayed for a determined time so the current selected palette is not synchronised with the current notification.

Steps to reproduce the bug

  1. Use RGUI with old notification style (linux notification style ? Or is it related to SDL 1.2 ?)
  2. run gamebatte core
  3. press L and R multiple time to observe the lack of synchronisation

Version/Commit

You can find this information under Information/System Information

  • RetroArch: [version/commit]
    10.0.0

Environment information

  • OS: Linux on Miyoo Mini
  • Compiler: GCC, SDL 1.2
@schmurtzm
Copy link
Author

May be the solution is around this : https://github.com/jdgleaver/gambatte-libretro/blob/master/libgambatte/libretro/libretro.cpp#L605

Here the RA notifications parameters description :
https://github.com/libretro/RetroArch/blob/master/libretro-common/include/libretro.h#L3082

I tried RETRO_MESSAGE_TYPE_NOTIFICATION instead of RETRO_MESSAGE_TYPE_NOTIFICATION_ALT without more success.

Or may be it's more related to Retroarch. The change save state slot notification seems to be overrided as expected.

schmurtzm added a commit to schmurtzm/Onion that referenced this issue Oct 31, 2022
- update to the last libretro commit  (7e02df60048db0898131ea365f387a026e4e648d)
- shorter time of palette change notification (cf. libretro/gambatte-libretro#238)
Aemiii91 added a commit to OnionUI/Onion that referenced this issue Nov 9, 2022
* Update .atari800.cfg

typo fix : ATARIOSA.ROM in upcase , atari800 core is not key sensitive with bios.

* Update OpenBOR with Steward-Fu version

Shrinked version of  OpenBor from Steward-Fu (openbor_20220422) :
Doesn't requires Parasyte framework, only essential files have been kept.

* Amiga replace puae core with puae 2021

Recommended for low hardware, should fix slowdowns with parallax scrolling effect games and fixes a lot of things like compatibility and auto-zoom mode.
Chd files now works perfectly.

Builded from https://github.com/libretro/libretro-uae/tree/2.6.1
Commit c68404cf2e83f1136a45b7b3d3f775c619d9d35f   (Sep 12, 2022)

* add amiga capsimg.so (ipf library)

capsimg.so is required to load .ipf roms

This one is compatible and comes from :
https://github.com/midwan/amiberry/releases/download/v2.25/amiberry-rpi-v2.25.zip

* Mutualize libraries from Parasyte framework

Centalize libraries from Parasyte (credits : Steward-Fu), only the one required for :
 - OpenBor
 - Sorr
 - FFplay

Modify launch.sh from OpenBOR to use this new libraries path.

* Default core configuration for Atari800

Improve game compatibility, credits ilmenit
https://discord.com/channels/529983248114122762/931367023588569180/1035795510080049242

* add FFplay (video player) to Apps

Based on Steward-Fu's FFmpeg :
https://github.com/steward-fu/miyoo-mini/releases

Modified by BoboTraX
https://discord.com/channels/529983248114122762/1007796369785897090/1017450491384434779

Scripted by Schmurtz :
https://discord.com/channels/529983248114122762/1007796369785897090/1035385517086347334

* Change default GBA emulator gpSP -> mGBA

- Switch gpSP and mGBA :
mGBA is now the default GBA emulator, replacing gpSP for better compatibility.
gpSP remains available in the expert section, you won't lose any saves or states.
- new gpSP icon for expert section
- new launch script for mGBA : informs of the change and propose to migrate gamesaves.

* add pico8 / Fake-08 libretro core

- add libretro fake08 core v0.0.2.19
- standalone version updated and moved to expert section
- new icone for standalone version

* Update ScummVM core to 2.7

1 - Games are now automatically imported in Onion thanks to a new importing script created by Onion's Team : no manual shortcuts to create !
2 - The shortcuts created are now .target and respect the recommendations from the ScummVM team to run a game and have the right configuration applied.
3 - A new very important option has been added to the core : "Target FPS for stutter reduction"  allows to run some heavy games with less audio stuttering on the Miyoo Mini. Default value is 55fps and correspond to an audio buffer of about 800 set it to 20 or 30 fps to obtain a buffer of 2000 which helps with heavy games  like Borken Sword 2.5. For Grim Fandango you can set it to 10 or 15.
4 - kyra.dat is now in the right version and allow to run westwood games without problem
5 - The list of compatible games is now a lot bigger and include titles like Grim Fandango or Borken Sword 2.5.

* Update DOSBox Pure to 0.9.7

No more limitation to 16 keyboard bindings with mouse mode.
(DOSBox Pure main author made a workaround in version 0.9.0, but the Mini still runs an older core.)
https://discord.com/channels/529983248114122762/891336865540620338/1029039263922274395

* update PCSX-ReARMed core & standalone

- based on last pcsx commit (4134c62)
- Improve the game compatibility on standalone thanks to the update : now colin 2.0 runs correctly.
- Some little improvements in configuration

* Update gambatte_libretro.so

- update to the last libretro commit  (7e02df60048db0898131ea365f387a026e4e648d)
- shorter time of palette change notification (cf. libretro/gambatte-libretro#238)

* disable color correction on GB / Gambatte

To avoid "super washed out image"

https://www.reddit.com/r/MiyooMini/comments/xgu5cy/comment/ioviaev/?utm_source=share&utm_medium=web2x&context=3

https://discord.com/channels/529983248114122762/1007796369785897090/1020966387801391105

* update vice x64 / Commodore Core

update from af699397ba7b44dc48316277f1a7a24c845f7935
to af699397ba7b44dc48316277f1a7a24c845f7935

https://github.com/libretro/vice-libretro

* Update MAME 2003-Plus.cfg

Now a savestate will be done when we exit a mame game but it still not be restored automatically : to avoid bugs (libretro/mame2003-plus-libretro#1433) it is better to let the user load the savestate manually once the game is totally launched.

* Update PCSX_rearmed to 7e6d030

- Update PCSX_rearmed (libretro core and standalone) as last commits include some game fix.
- Update PCSX-ReARMed.cfg to use SDL audio instead of OSS : it allows to activate auto frameskip in a easier way for users.

* Update scummvm_libretro.info

https://github.com/libretro/libretro-super/blob/master/dist/info/scummvm_libretro.info

* add M.B.A-mini core

Following this issue :
#598

(Great for IREM M92 games )

Core added from this release :
https://github.com/wonder199999/MBA.mini-libretro/releases/tag/05-15-2019

(mba.mini_linux_generic_arm_hardfloat.tar.gz)

* Add PDF viewer (Green)

Add a PDF viewer based on Green pdf reader :
https://github.com/schandinat/green

Version compiled for the Miyoo Mini by Steward-Fu :
https://github.com/steward-fu/miyoo-mini/releases/tag/stock

Add required libraries for Green from Parasyte framework

Add icon for PDF viewer and better icon for FFplay

Little bug fix in FFplay launcher script.

* Update ZX Spectrum core (Fuse) to 3f9344d

- From commit 3371042 to 3f9344d
- Contains fix, support zip files, support map keyboard arrow keys to Spectrum keyboard
- Save states still compatible

* Update Amiga core (puae 2021)

- Update puae 2021 - v2.6.1 from commit c68404c to 1ca4048
https://github.com/libretro/libretro-uae/tree/2.6.1
- Add RAW floppy extension
- Save states still compatible

* Update mame2003_plus_libretro.so

- Update mame2003-plus from commit 8f1498ff to 4bf97d5
https://github.com/libretro/mame2003-plus-libretro
- Many fixes on various games
- Save states are not compatible with previous version !!!

* mGBA : R2 to fast forward & configs

Include modified mGBA core version which allows to map R2 to fast forward (without pressing hotkey). Still based on 0.10.0 (ec5ecb2)

Used repo :
libretro/mgba@99387c0

Issue / Official Feature Request :
on the core : libretro/mgba#273
on retroarch frontend : libretro/RetroArch#14590

-----
some config updates :
- Update mGBA.cfg to use SDL audio instead of OSS : it allows to activate auto frameskip in a easier way for users.
- activate color correction by default for GBA games

* details fixes

- Update mGBA.cfg to use SDL audio instead of OSS : it allows to activate auto frameskip in a easier way for users.
- enable mGBA rumble by default
- little fixes

Co-authored-by: Schmurtz <Schmurtz@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant