-
-
Notifications
You must be signed in to change notification settings - Fork 2k
Add speech-dispatcher support (linux-only for now) #17761
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Any downsides with us moving over to this? Will it break some people's setup that relied on espeak instead? |
Those who have only |
Is there a way to support both? |
I say if you can put in a setting where you can select between espeak and speak-dispatcher so that we can retain the ability to use either of them then that is a PR I could merge. Unless there's a better way to do that without a setting but I could see that as being a compromise |
We could enable speech-dispatcher and add to the changelog that you have to install espeak module for speech-dispatcher to keep compatibility. Currently, RA supports only espeak on Linux/Unix but with speech-dispatcher we can get access to other TTS engines for "free". Moreover, speech-dispatcher is packaged for a lot of distributions and for example on Debian it is used more than espeak(-ng). Source. |
87a0c47
to
91491d6
Compare
Sorry for the delay, I don't have much free time right now. I added an engine selection item to the menu with restricted the visibility to Linux only at this stage. The code is working, but may not be very neat and may require refactoring. P.S. these changes should not affect users who are currently using eSpeak |
b8477ee
to
d30e8cf
Compare
d30e8cf
to
649615c
Compare
I hope the retroarch guys pull your pull request, this is badly needed. |
Use a high-level
speech-dispacher
as the linux narrator. It supports many TTS engines, including eSpeak. It allows to use the preferred TTS engine that is may already be configured in the system/user environment.