qb: Improve the gnu99 compiler check.#10012
Merged
inactive123 merged 1 commit intolibretro:masterfrom Jan 15, 2020
orbea:c99
Merged
qb: Improve the gnu99 compiler check.#10012inactive123 merged 1 commit intolibretro:masterfrom orbea:c99
inactive123 merged 1 commit intolibretro:masterfrom
orbea:c99
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This attempts to improve the
gnu99/c99compiler check.Reviewers
@twinaphex Please read this to make sure you agree with this logic.
Currently RetroArch checks if
-std=gnu99works or will error during configure when it doesn't. Then in theMakefileit will use-std=gnu99unless the compiler isiccwhere it will use-std=c99.With this PR RetroArch will check if
-std=gnu99works and then will check-std=c99if the previous check has failed. If both checks fail it will then error during configure. This allows removing the compiler check in theMakefilewhich will presumably always have the working compiler flag.This will also remove the
GNU90_BUILDcheck in theMakefilewhich is entirely unused elsewhere and doesn't seem all that useful.First does anyone actually use
iccto compile RetroArch? Bothgccandclangare much better choices today.Second should we be using
-std=gnu99instead of-std=c99? Both seem to compile and work without noticeable difference.