The wrong autoconfig file is matched (weighted score system)

[kivutar]

Depending in what order the input autoconfig files are read, you will get a wrong config.

For example, if Xbox_360_Wireless_Receiver.cfg is read before Microsoft_X-Box_360_pad.cfg, you will get the Xbox_360_Wireless_Receiver for your Microsoft_X-Box_360_pad. Because input_autoconfigure_joypad_from_conf_dir will get the first config with a matching vid:pid, and those two config files share the same vid:pid.

To fix that, we must give priority to the file that matches the name:vid:pid triplet, and then fallback to file that matches just vid:pid, and finally to file that matches just the name.

Every config file that does not match the input_driver must be ignored, as it is already the case.

[sergiobenrocha2]

Xbox_360_Wireless_Receiver has no more the same id, I think that one was from the joystick recharger, not from the receiver.

[andres-asm]

kivutar, check it now, I made a weighted score system it works nicely here

On Thu, Jul 9, 2015 at 11:42 PM, sergio-br2 notifications@github.com
wrote:

Xbox_360_Wireless_Receiver has no more the same id, I think that one was
from the joystick recharger, not from the receiver.

—
Reply to this email directly or view it on GitHub
#1933 (comment)
.

[kivutar]

@fr500 your weighted score system fixes that bug. Thanks.
@sergiobenrocha2 are you sure? Your receiver is the official one?

[sergiobenrocha2]

@kivutar take a look at libretro/retroarch-joypad-autoconfig#38, I posted some photos there. I think it's the official, but I'm not sure.

Bus 008 Device 003: ID 045e:0719 Microsoft Corp. Xbox 360 Wireless Adapter

[sergiobenrocha2]

My receive is getting the config from both Xbox_360_Wireless_Receiver.cfg and Xbox_360_Wireless_Receiver_Chinese01.cfg (I mv one, and it get from the other)

[sergiobenrocha2]

With both config installed, it get from the wrong one (Chinese01, which has product id = 657)

my receiver has product ID = 1817

[andres-asm]

the pid/vid must be expressed in decimal format

[andres-asm]

If you can paste a verbose log I can try to figure out why it's picking the wrong one

[sergiobenrocha2]

I git pull, it's working now, sorry.

Btw, 1817 is the decimal of 0719.

[sergiobenrocha2]

I removed the Xbox_360_Wireless_Receiver.cfg, and it's fallbacking to Xbox_360_Wireless_Receiver_Chinese01.cfg. Is it right?

[kivutar]

Falling back is normal, because both config files and devices share the same input_device.

If you compare the two files, you will see that the only difference is the pid and the L and R recognized either as axis or buttons. As you expressed on the other topic.

Most important, is it working now?

[sergiobenrocha2]

Yup, it's working fine now.