Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Match autoconf build in terms of HAVE_AES macros #1062

Merged
merged 1 commit into from
May 31, 2024

Conversation

botovq
Copy link
Contributor

@botovq botovq commented May 29, 2024

Noticed that this was missed when trying to run tests with cmake on an old core2 duo laptop. Apparently our CI doesn't run on such old targets.

@botovq
Copy link
Contributor Author

botovq commented May 29, 2024

I have no idea what's up with the cancelled and skipped CI. @joshuasing you're smart enough to deal with this stuff. Can you please take a look?

@joshuasing
Copy link
Member

joshuasing commented May 29, 2024

I have no idea what's up with the cancelled and skipped CI. @joshuasing you're smart enough to deal with this stuff. Can you please take a look?

Hmm, I'm not sure what caused that weird behaviour. I have re-run all of the jobs, so I'll see whether they all pass now.

This possibly could have been caused by the concurrency group not including the pull request number, and only the ref - but I am pretty sure the reference is the commit hash, so unless you also pushed the commit to another branch that triggered CI on this repository, I am not sure why it was cancelled. I will see if I can reproduce this so we don't have it happen again.

@botovq
Copy link
Contributor Author

botovq commented May 29, 2024

fwiw, it also happened twice in my fork: https://github.com/botovq/libressl-portable/tree/aes-asm

@botovq
Copy link
Contributor Author

botovq commented May 29, 2024 via email

@joshuasing
Copy link
Member

It also happened in the scheduled runs on the main repo libressl/portable/actions/runs/9278269374 Maybe it's just a hiccup in github's CI infra.

Wouldn't surprise me, however GitHub hasn't published an incident on their status page yet so I'm not sure.
It appears as so one of the runs was cancelled again, I think I will open a pull request to adjust the concurrency groups just in-case they're causing it.

@botovq
Copy link
Contributor Author

botovq commented May 30, 2024 via email

@botovq botovq merged commit 3e097f8 into libressl:master May 31, 2024
48 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants