oauth: retain refresh token when refresh response omits it - #1732
Open
httpsworldview wants to merge 1 commit into
Open
oauth: retain refresh token when refresh response omits it#1732httpsworldview wants to merge 1 commit into
httpsworldview wants to merge 1 commit into
Conversation
Signed-off-by: Maika Namuo <httpworldview@gmail.com>
MichaelPachec0
added a commit
to MichaelPachec0/ncspot
that referenced
this pull request
Jul 30, 2026
Spotify's token endpoint stopped including a refresh_token in refresh-grant responses (optional per RFC 6749 §6). librespot-oauth assumed it was always present and overwrote the stored token with an empty string, which ncspot then persisted to rspotify_token.json — breaking every subsequent refresh and forcing interactive browser re-auth on each token expiry. Bump the [patch.crates-io] pin from db1ef7a to db65eb1, the head of librespot-org/librespot#1732, which retains the previous refresh token when the response omits one. The new rev sits on the dev tip and includes the previously pinned CDN-fallback fix (hrkfdn#1722), so nothing is lost. Update flake.nix outputHashes for the new rev accordingly. Drop the pin once a librespot release containing hrkfdn#1722 and hrkfdn#1732 is published. Signed-off-by: Michael Pacheco <git@michaelpacheco.org>
MichaelPachec0
added a commit
to MichaelPachec0/ncspot
that referenced
this pull request
Jul 30, 2026
Spotify's token endpoint stopped including a refresh_token in refresh-grant responses. librespot-oauth assumed it was always present and overwrote the stored token with an empty string, which ncspot then persisted to rspotify_token.json — breaking every subsequent refresh and forcing interactive browser re-auth on each token expiry. Bump the [patch.crates-io] pin from db1ef7a to db65eb1, the head of librespot-org/librespot#1732, which retains the previous refresh token when the response omits one. The new rev sits on the dev tip and includes the previously pinned CDN-fallback fix (hrkfdn#1722), so nothing is lost. Update flake.nix outputHashes for the new rev accordingly. Drop the pin once a librespot release containing hrkfdn#1722 and hrkfdn#1732 is published. Signed-off-by: Michael Pacheco <git@michaelpacheco.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Spotify may omit refresh_token from successful refresh responses.
librespotshould reuse the submitted token unless Spotify provides a replacement, preventing consumers from persisting an empty token and possibly requiring re-authentication every few hours.