-
-
Notifications
You must be signed in to change notification settings - Fork 113
lime-proto-batadv remove retrocompatibility #1012
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lime-proto-batadv remove retrocompatibility #1012
Conversation
|
The code looks good but it still does not pass the tests |
Yesss, someone should prepare a Docker image for testing on top of OpenWrt 22.03. |
|
It is not clear to me why tests stop working do you know which merge broke them, and I dont see why it is related to 22.03 as the tests are unit tests of lua files mostly, some libs like uci are from openwrt but if we are not using new features then it should continue working. So it seems that some merged code was merged and broke the tests. Finding which one will help fix it |
|
It was expected to happen with #959 which is when we abandoned the support on OpenWrt 19.07 in the master branch. |
|
Indeed, the fails in these tests refer to the names of the ethernet interfaces https://github.com/libremesh/lime-packages/pull/959/checks |
|
For example, this commit stops looking for interfaces using the pre-OpenWrt 21.02 naming. |
|
Indeed but the issue is that the tests need to be updated, not the test image |
Ooooohhh, ok, I did not expect that. |
The support for the new configuration style for Batman-adv has been introduced in fed6a46
Here I remove the new configuration style.
I did not test yet, but the edit is simple enough that I hope I didn't break anything.