Skip to content

Conversation

@ilario
Copy link
Member

@ilario ilario commented Apr 13, 2023

The support for the new configuration style for Batman-adv has been introduced in fed6a46

Here I remove the new configuration style.
I did not test yet, but the edit is simple enough that I hope I didn't break anything.

@ilario ilario requested a review from spiccinini April 13, 2023 07:45
@spiccinini
Copy link
Contributor

The code looks good but it still does not pass the tests

@ilario
Copy link
Member Author

ilario commented Apr 13, 2023

The code looks good but it still does not pass the tests

Yesss, someone should prepare a Docker image for testing on top of OpenWrt 22.03.

@ilario ilario merged commit d469249 into libremesh:master Apr 13, 2023
@spiccinini
Copy link
Contributor

It is not clear to me why tests stop working do you know which merge broke them, and I dont see why it is related to 22.03 as the tests are unit tests of lua files mostly, some libs like uci are from openwrt but if we are not using new features then it should continue working. So it seems that some merged code was merged and broke the tests. Finding which one will help fix it

@ilario
Copy link
Member Author

ilario commented Apr 14, 2023

It was expected to happen with #959 which is when we abandoned the support on OpenWrt 19.07 in the master branch.

@ilario
Copy link
Member Author

ilario commented Apr 14, 2023

Indeed, the fails in these tests refer to the names of the ethernet interfaces https://github.com/libremesh/lime-packages/pull/959/checks

@ilario
Copy link
Member Author

ilario commented Apr 14, 2023

For example, this commit stops looking for interfaces using the pre-OpenWrt 21.02 naming.
90fbb45

@spiccinini
Copy link
Contributor

Indeed but the issue is that the tests need to be updated, not the test image

@ilario
Copy link
Member Author

ilario commented Apr 15, 2023

Indeed but the issue is that the tests need to be updated, not the test image

Ooooohhh, ok, I did not expect that.
I am slowly fixing the failing tests. But I can already tell you that I have no LibreRouter with me for updating these files:
https://github.com/libremesh/lime-packages/tree/master/tests/devices/librerouter-v1

@ilario ilario mentioned this pull request May 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants