Skip to content

Conversation

@vinceh121
Copy link
Contributor

These changes allow users to configure the server's listen address.
0.0.0.0 is still the default.

@hrj
Copy link
Contributor

hrj commented May 19, 2021

Thanks @vinceh121

Can you please sign the DCO? Details at:
https://github.com/librecaptcha/lc-core/pull/94/checks?check_run_id=2618926447

(Since it's a minor change, I can merge without DCO, but it would be good if you do sign it; thanks)

vinceh121 added 2 commits May 19, 2021 14:32
Signed-off-by: vinceh121 <contact@vinceh121.me>
Signed-off-by: vinceh121 <contact@vinceh121.me>
@vinceh121
Copy link
Contributor Author

Commits are signed-off now

@hrj hrj merged commit ab9c0e6 into librecaptcha:master May 19, 2021
@hrj
Copy link
Contributor

hrj commented May 19, 2021

Thanks @vinceh121

Would be thrilled to know if you use the project. Please do share a link when you can.

@vinceh121
Copy link
Contributor Author

I am using LibreCaptcha in my GMCServer project for account registration, works like a charm!

@hrj
Copy link
Contributor

hrj commented May 20, 2021

Great! From a quick search in that repo, it seems like you are using text CAPTCHA? Have you created your own custom text CAPTCHAs?

@vinceh121
Copy link
Contributor Author

I didn't create a custom CAPTCHA provider if that's what you're asking, although my implementation works with any type of CAPTCHA, as long as they don't require custom properties.

@hrj
Copy link
Contributor

hrj commented May 20, 2021

Oh ok.

My question was wrong; I saw input-type=text in there and wrongly thought that the challenge type was text. And since we haven't implemented text captchas yet, I thought you might have implemented a custom one. 🤦🏽

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants