Skip to content

Conversation

@blackmagic0
Copy link
Contributor

  • Added configuration to set Access-Control-Allow-Origin header value on responses.
  • Added configuration to disable serving the playground webpage.

jacobp added 2 commits December 6, 2021 10:47
…figuration to set Access-Control-Allow-Origin header value on responses.
…figuration to set Access-Control-Allow-Origin header value on responses.

Signed-off-by: jacobp <mozillafirefox1>
@hrj
Copy link
Contributor

hrj commented Dec 6, 2021

Hi @JacobPozaic, Thanks for the contrib. Will be happy to merge once the checks pass.

The error in CI was this:


Error: Exception in thread "main" org.json4s.package$MappingException: Did not find value which can be converted into boolean
	at org.json4s.reflect.package$.fail(package.scala:95)
	at org.json4s.Extraction$.$anonfun$convert$2(Extraction.scala:735)
	at scala.Option.getOrElse(Option.scala:201)
	at org.json4s.Extraction$.convert(Extraction.scala:735)
	at org.json4s.Extraction$.$anonfun$extract$10(Extraction.scala:410)
	at org.json4s.Extraction$.$anonfun$customOrElse$1(Extraction.scala:637)
	at scala.PartialFunction.applyOrElse(PartialFunction.scala:189)
	at scala.PartialFunction.applyOrElse$(PartialFunction.scala:188)
	at scala.PartialFunction$$anon$1.applyOrElse(PartialFunction.scala:342)
	at org.json4s.Extraction$.customOrElse(Extraction.scala:637)
	at org.json4s.Extraction$.extract(Extraction.scala:408)
	at org.json4s.Extraction$.extract(Extraction.scala:40)
	at org.json4s.ExtractableJsonAstNode.extract(ExtractableJsonAstNode.scala:21)
	at lc.core.Config.<init>(config.scala:48)
	at lc.LCFramework$.main(Main.scala:14)
	at lc.LCFramework.main(Main.scala)

Note that we do this just before running the locust tests:

cp tests/debug-config.json data/config.json

I think you need to add the new config options in tests/debug-config.json

@blackmagic0
Copy link
Contributor Author

Test should pass now I think

@hrj
Copy link
Contributor

hrj commented Dec 8, 2021

Yes, it's passing! Please sign the DCO as per these instructions:
https://github.com/librecaptcha/lc-core/pull/101/checks?check_run_id=4448790832

rr83019 and others added 7 commits December 8, 2021 13:02
Signed-off-by: Rahul Rudragoudar <rr83019@gmail.com>
Signed-off-by: JacobPozaic <jacobpozaic@gmail.com>
Signed-off-by: Rahul Rudragoudar <rr83019@gmail.com>
Signed-off-by: JacobPozaic <jacobpozaic@gmail.com>
Make fn static

Signed-off-by: Rahul Rudragoudar <rr83019@gmail.com>
Signed-off-by: JacobPozaic <jacobpozaic@gmail.com>
Signed-off-by: Rahul Rudragoudar <rr83019@gmail.com>
Signed-off-by: JacobPozaic <jacobpozaic@gmail.com>
Signed-off-by: Rahul Rudragoudar <rr83019@gmail.com>
Signed-off-by: JacobPozaic <jacobpozaic@gmail.com>
…figuration to set Access-Control-Allow-Origin header value on responses.

Signed-off-by: jacobp <mozillafirefox1>
Signed-off-by: JacobPozaic <jacobpozaic@gmail.com>
Signed-off-by: JacobPozaic <jacobpozaic@gmail.com>
@blackmagic0
Copy link
Contributor Author

@hrj I cant seem to get that DCO thing to pass. I've tried a few times following the instructions and trying to clone a few different ways, Any ideas on how to rectify this?

@hrj
Copy link
Contributor

hrj commented Dec 9, 2021

@JacobPozaic Thanks for your patience with this one! I think you shouldn't merge with origin/master, but rather rebase to origin/master. When you rebase, your commits will be "replayed" on top of the master branch.

Try this: git rebase origin/master. Now git log should show only your commits on top.
After that, force push the branch. And then follow the DCO instructions. (Just copy pasting them should work)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants