-
Notifications
You must be signed in to change notification settings - Fork 18
CORS configuration and disable playground #101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
blackmagic0
commented
Dec 6, 2021
- Added configuration to set Access-Control-Allow-Origin header value on responses.
- Added configuration to disable serving the playground webpage.
…figuration to set Access-Control-Allow-Origin header value on responses.
…figuration to set Access-Control-Allow-Origin header value on responses. Signed-off-by: jacobp <mozillafirefox1>
|
Hi @JacobPozaic, Thanks for the contrib. Will be happy to merge once the checks pass. The error in CI was this: Note that we do this just before running the locust tests: I think you need to add the new config options in |
|
Test should pass now I think |
|
Yes, it's passing! Please sign the DCO as per these instructions: |
Signed-off-by: Rahul Rudragoudar <rr83019@gmail.com> Signed-off-by: JacobPozaic <jacobpozaic@gmail.com>
Signed-off-by: Rahul Rudragoudar <rr83019@gmail.com> Signed-off-by: JacobPozaic <jacobpozaic@gmail.com>
Make fn static Signed-off-by: Rahul Rudragoudar <rr83019@gmail.com> Signed-off-by: JacobPozaic <jacobpozaic@gmail.com>
Signed-off-by: Rahul Rudragoudar <rr83019@gmail.com> Signed-off-by: JacobPozaic <jacobpozaic@gmail.com>
Signed-off-by: Rahul Rudragoudar <rr83019@gmail.com> Signed-off-by: JacobPozaic <jacobpozaic@gmail.com>
…figuration to set Access-Control-Allow-Origin header value on responses. Signed-off-by: jacobp <mozillafirefox1> Signed-off-by: JacobPozaic <jacobpozaic@gmail.com>
Signed-off-by: JacobPozaic <jacobpozaic@gmail.com>
|
@hrj I cant seem to get that DCO thing to pass. I've tried a few times following the instructions and trying to clone a few different ways, Any ideas on how to rectify this? |
|
@JacobPozaic Thanks for your patience with this one! I think you shouldn't Try this: |