Support newer versions of metabase #8
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 3, 2020 10:04
…en", not "setup_token" in metabase 37
Collaborator
|
Thanks @hauthorn! ❤️ I'm currently using Metabase |
Collaborator
|
@hauthorn I've tested, merged, released and updated Ansible Galaxy 👍 You can bump |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While trying out your role with v0.37.0.2, I noticed a bug in
tasks/configure.ymlthat would cause an error.The response from
http://localhost:{{ metabase_port }}/api/session/propertieswould response with the setup token under the keysetup-token(with a dash) and not with an underscore.This caused the configuration to fail because the code could not look up the value in the dictionary. (tested on Ansible 2.9.* and python 3.8.* on Ubuntu)
I hope this is useful to you - feel free to ask me to change something or test something to help you merge this.