Skip to content

Conversation

@mcg
Copy link
Contributor

@mcg mcg commented Aug 13, 2019

Fixes #1

Didn't use default(omit) as you suggested as that's apparently not the intended usage for omit. See ansible/ansible#44261 for some explanation.

mcg added 2 commits August 13, 2019 16:22
` Invalid environment assignment, ignoring: "MB_PASSWORD_COMPLEXITY=normal" # <weak|normal|strong>`
@Matt-Yorkley
Copy link
Collaborator

Didn't use default(omit) as you suggested

Ah yes, it's a template so omit doesn't work, but we could have used: {{ metabase_jvm_args | default("") }}. Anyway, it's fine like this. 👍

@Matt-Yorkley Matt-Yorkley merged commit 0080eb5 into libre-ops:master Aug 13, 2019
@Matt-Yorkley
Copy link
Collaborator

Hey @mcg I did some testing and added this as well: #3.

There's now a new release: https://github.com/libre-ops/metabase/releases/tag/1.0.2 and it's up on ansible galaxy.

@mcg
Copy link
Contributor Author

mcg commented Aug 13, 2019

Thanks for getting this pushed out . Didn’t want to have to use my branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow customizing ExecStart command

2 participants