Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: bump @libp2p/websockets from 8.0.20 to 8.0.22 in js-peer #139

Merged

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github May 6, 2024

Bumps @libp2p/websockets from 8.0.20 to 8.0.22.

Release notes

Sourced from @​libp2p/websockets's releases.

websockets: v8.0.22

8.0.22 (2024-05-01)

Bug Fixes

Dependencies

  • The following workspace dependencies were updated
    • dependencies
      • @​libp2p/interface bumped from ^1.3.0 to ^1.3.1
      • @​libp2p/utils bumped from ^5.3.2 to ^5.4.0
    • devDependencies
      • @​libp2p/interface-compliance-tests bumped from ^5.4.2 to ^5.4.3
      • @​libp2p/logger bumped from ^4.0.11 to ^4.0.12

websockets: v8.0.21

8.0.21 (2024-04-24)

Documentation

Dependencies

  • The following workspace dependencies were updated
    • dependencies
      • @​libp2p/interface bumped from ^1.2.0 to ^1.3.0
      • @​libp2p/utils bumped from ^5.3.1 to ^5.3.2
    • devDependencies
      • @​libp2p/interface-compliance-tests bumped from ^5.4.1 to ^5.4.2
      • @​libp2p/logger bumped from ^4.0.10 to ^4.0.11
Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code labels May 6, 2024
Copy link

vercel bot commented May 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
universal-connectivity ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 7, 2024 1:59pm

Bumps [@libp2p/websockets](https://github.com/libp2p/js-libp2p) from 8.0.20 to 8.0.22.
- [Release notes](https://github.com/libp2p/js-libp2p/releases)
- [Changelog](https://github.com/libp2p/js-libp2p/blob/main/.release-please.json)
- [Commits](libp2p/js-libp2p@websockets-v8.0.20...websockets-v8.0.22)

---
updated-dependencies:
- dependency-name: "@libp2p/websockets"
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/js-peer/libp2p/websockets-8.0.22 branch from 76f69e1 to e75bbff Compare May 7, 2024 13:58
@maschad maschad changed the title deps: bump @libp2p/websockets from 8.0.20 to 8.0.22 in /js-peer deps: bump @libp2p/websockets from 8.0.20 to 8.0.22 in js-peer May 7, 2024
@maschad maschad merged commit 6bdb1fc into main May 7, 2024
7 checks passed
@maschad maschad deleted the dependabot/npm_and_yarn/js-peer/libp2p/websockets-8.0.22 branch May 7, 2024 16:46
@2color
Copy link
Collaborator

2color commented May 8, 2024

@maschad Did you test the changes here?

This PR seems to have introduced a regression. When libp2p is started, it throws an error:

failed to start libp2p TypeError: n.filter is not a function
    at fM.listen (transport-manager.js:141:1)
    at fM.afterStart (transport-manager.js:48:1)
    at components.js:23:1
    at Array.map (<anonymous>)
    at Proxy._invokeStartableMethod (components.js:22:1)
    at Proxy.afterStart (components.js:34:1)
    at fX.start (libp2p.js:170:1)
    at async f1 (index.js:46:1)
    at async vJ (libp2p.ts:31:18)
    at async ctx.tsx:30:24

Seems related to libp2p/js-libp2p#2515

@2color 2color mentioned this pull request May 8, 2024
@maschad
Copy link
Member

maschad commented May 8, 2024

@2color good catch, that was my bad. I had mistaken that the CI tests we had included the js-peer.

@2color
Copy link
Collaborator

2color commented May 8, 2024

No worries! Solved now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants