Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(perf): add go-libp2p v0.29 #242

Merged
merged 2 commits into from
Jul 26, 2023
Merged

feat(perf): add go-libp2p v0.29 #242

merged 2 commits into from
Jul 26, 2023

Conversation

mxinden
Copy link
Member

@mxinden mxinden commented Jul 25, 2023

More specifically https://github.com/libp2p/go-libp2p/releases/tag/v0.29.0.

Note the only change compared to perf/impl/go-libp2p/v0.28 is a %s/0\.28/0.29.

@mxinden
Copy link
Member Author

mxinden commented Jul 25, 2023

From taking a quick look, no regressions.

newplot(4)
newplot(5)

See https://observablehq.com/@libp2p-workspace/performance-dashboard with branch perf-go-libp2p-v0.29.

@sukunrt
Copy link
Member

sukunrt commented Jul 26, 2023

@marten-seemann should we have one with GSO enabled or should we wait for quic-go/quic-go#3911 fix.

@mxinden
Copy link
Member Author

mxinden commented Jul 26, 2023

@marten-seemann should we have one with GSO enabled or should we wait for quic-go/quic-go#3911 fix.

Will proceed and merge here. Happy to follow-up on whatever this discussion might yield.

@mxinden mxinden merged commit 35eb403 into master Jul 26, 2023
@mxinden mxinden deleted the perf-go-libp2p-v0.29 branch July 26, 2023 12:01
@marten-seemann
Copy link
Contributor

Let's test the configuration that we ship with and that users are most likely be running in production. That's why we removed the multistream hacks that made it look like our handshake performs better than it actually does.

@BigLep
Copy link
Contributor

BigLep commented Jul 31, 2023

@libp2p/go-libp2p-maintainers @mxinden : how do we make sure this is part of our release process? Update https://github.com/libp2p/go-libp2p/blob/master/.github/ISSUE_TEMPLATE/release.md ?

@marten-seemann
Copy link
Contributor

@BigLep There’s libp2p/go-libp2p#2442. I’ve suggested a few changes. Let’s keep the discussion on that PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants