feat(interop): add rust-libp2p chromium WASM WebTransport #217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rt test Introduced in rust-libp2p with libp2p/rust-libp2p#4015.
mxinden
changed the title
thomaseizinger
approved these changes
Jul 3, 2023
There was a problem hiding this comment.
Thanks @mxinden ! Still can't believe we have tests for this now, so exciting!
Looking forward to extending support for this for WebSocket and WebRTC!
Same. //CC @zvolin. |
|
Note that rust-libp2p WebTransport tests are not triggered yet. Need to investigate. Maybe related to #218. |
|
Excited too :) they indeed look great after your reviews |
Thank you @thomaseizinger! That helped. Proposed fix in #219. |
|
|
|
@MarcoPolo since you set-up the js-libp2p part, let me know in case you want any follow-ups. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduced in rust-libp2p with libp2p/rust-libp2p#4015.