Skip to content

fix(request-response): don't fail requests on DialPeerConditionFalse #6000

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

fix(request-response): don't fail requests on DialPeerConditionFalse #6000

wants to merge 4 commits into from

Conversation

elenaf9
Copy link
Contributor

@elenaf9 elenaf9 commented Apr 21, 2025 •
edited
Loading

Description

If a dial fails because of an unmet peer condition, it just means that there is already an ongoing dial.
We shouldn't fail the pending outbound requests to the peer in that case.

Fixes #5996.

Notes & open questions

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • A changelog entry has been made in the appropriate crates

@elenaf9 elenaf9 changed the title fix(request-response): don't fail outbound request on DialError::DialPeerConditionFalse fix(request-response): don't fail requests on DialPeerConditionFalse Apr 21, 2025
@elenaf9 elenaf9 mentioned this pull request Apr 21, 2025
Open
dariusc93
dariusc93 approved these changes Apr 21, 2025
View reviewed changes
Copy link
Member

@dariusc93 dariusc93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dariusc93 dariusc93 dariusc93 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

request_response (at least!) cancels its own dials due to race condition
2 participants
@elenaf9 @dariusc93