Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add libp2p-mdns #590

Merged
merged 20 commits into from
Nov 24, 2018
Merged

Add libp2p-mdns #590

Changes from 1 commit
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
4e9fef7
Add libp2p-mdns
tomaka Oct 22, 2018
6c4ad95
Fix win32
tomaka Oct 27, 2018
f1e0c49
Make compatible with Rust 1.29
tomaka Oct 27, 2018
795f7e2
Remove mDNS on esmcripten
tomaka Oct 28, 2018
185645f
Merge remote-tracking branch 'upstream/master' into mdns
tomaka Oct 29, 2018
183e4eb
Fix concerns
tomaka Oct 29, 2018
4b435ee
More concern
tomaka Oct 30, 2018
ff9b1c3
Use append_u16
tomaka Nov 2, 2018
8843055
Make decode_character_string return a Cow
tomaka Nov 2, 2018
323e3b0
Add TODO
tomaka Nov 2, 2018
0183bd5
Merge remote-tracking branch 'upstream/master' into mdns
tomaka Nov 21, 2018
7397397
Don't send queries from 5353
tomaka Nov 21, 2018
d748cf5
Fix flags
tomaka Nov 21, 2018
0bb3335
More flags fix
tomaka Nov 21, 2018
e68a788
More concerns
tomaka Nov 22, 2018
a67f550
Merge branch 'master' into mdns
tomaka Nov 22, 2018
e1e9745
Fix flags
tomaka Nov 23, 2018
cff276e
Merge branch 'master' into mdns
tomaka Nov 24, 2018
65b5ede
Fix removed env_logger
tomaka Nov 24, 2018
f812b27
Merge branch 'master' into mdns
tomaka Nov 24, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Use append_u16
  • Loading branch information
@tomaka
tomaka committed Nov 2, 2018
commit ff9b1c36d14d76f1d37fb0a748e6ce45d2abc30f
12 changes: 4 additions & 8 deletions misc/mdns/src/dns.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,10 +111,8 @@ pub fn build_query_response(
append_qname(&mut out, SERVICE_NAME);

// Flags.
out.push(0x00);
out.push(0x0c); // PTR record.
out.push(0x80);
out.push(0x01);
append_u16(&mut out, 0x000c);
append_u16(&mut out, 0x8001);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIUC this sets the flush-cache bit saying that this record is the sole truth. I guess this implies that this responder owns the name and no other responder is expected to answer that query.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I set this to 0x8000, then the dnsparser crate is incapable of parsing the response w generate. Not sure why.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Without the flush-cache-bit you would use 1 (internet class).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, ok!


// TTL for the answer
append_u32(&mut out, ttl);
Expand Down Expand Up @@ -171,10 +169,8 @@ pub fn build_service_discovery_response(id: u16, ttl: Duration) -> Vec<u8> {
append_qname(&mut out, META_QUERY_SERVICE);

// Flags.
out.push(0x00);
out.push(0x0c); // PTR record requested.
out.push(0x80);
out.push(0x01);
append_u16(&mut out, 0x000c);
append_u16(&mut out, 0x8001);

// TTL for the answer
append_u32(&mut out, ttl);
Expand Down