Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps(quic): upgrade quinn to address RUSTSEC-2023-0063 #4538

Merged
merged 1 commit into from
Sep 21, 2023

Conversation

divagant-martian
Copy link
Contributor

@divagant-martian divagant-martian commented Sep 21, 2023

Description

https://rustsec.org/advisories/RUSTSEC-2023-0063 was recently published, this address it.

Notes & open questions

na

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • A changelog entry has been made in the appropriate crates

@mergify
Copy link
Contributor

mergify bot commented Sep 21, 2023

This pull request has merge conflicts. Could you please resolve them @divagant-martian? 🙏

@divagant-martian
Copy link
Contributor Author

@mxinden you might want to include in #4537

@thomaseizinger
Copy link
Contributor

Thanks but if it is a patch-release, then users can upgrade that themselves!

We should update our lockfile of course but we don't need to mention that in the changelog :)

@divagant-martian
Copy link
Contributor Author

is your specific suggestion to simply remove the changelog @thomaseizinger?

@thomaseizinger
Copy link
Contributor

is your specific suggestion to simply remove the changelog @thomaseizinger?

Yes please! :)

@thomaseizinger
Copy link
Contributor

@mxinden you might want to include in #4537

Just to be clear: Releasing this PR has no effect for our users because they have their own lockfile.

@mergify mergify bot merged commit 89b4bf4 into libp2p:master Sep 21, 2023
87 of 97 checks passed
@divagant-martian
Copy link
Contributor Author

divagant-martian commented Sep 21, 2023

not sure if you noticed but #4537 has workflows failing because of this, thus it needs to be included, not referring to users, so yeah. we are on the same page :)

@thomaseizinger
Copy link
Contributor

not sure if you noticed but #4537 has workflows failing because of this, thus it needs to be included, not referring to users, so yeah. we are on the same page :)

Ah yes, thank you for that! We don't require those for merging because there isn't always an immediate solution available but it is good to be fixed, thank you! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants