feat/920-add-gossipsub-2.0-support #1066
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@Winter-Soren : Great efforts, Soham. Thank you for raising the PR. I will review all the Gossipsub 2.0 features that have been implemented. Appreciate the contribution. |
…vars, add None checks for scorer, fix test indentation and type narrowing
…e type checker treats it as non-None, allowing safe attribute access
pacrob
reviewed
Dec 22, 2025
Comment on lines
+1975
to
+1978
| if peer_ip not in current_ips: | ||
| # This peer would add IP diversity | ||
| selected.append(peer_id) | ||
| current_ips.add(peer_ip) |
Member
There was a problem hiding this comment.
peer_ip is not guaranteed to exist here. Maybe you meant to have it indented?
pacrob
reviewed
Dec 22, 2025
Comment on lines
+1740
to
+1746
| if score > scorer.params.graylist_threshold: | ||
| self.mesh[topic].add(peer) | ||
| # Note: In real implementation, we'd send GRAFT message | ||
| logger.debug( | ||
| "Grafted peer %s for IP diversity in topic %s", peer, topic | ||
| ) | ||
| grafted += 1 |
Member
There was a problem hiding this comment.
Why this comment? And why not emitting a GRAFT message here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
Issue #920
py-libp2p only supported Gossipsub 1.1, which limited its ability to handle adversarial network conditions and interoperate with modern libp2p implementations. The Python ecosystem was falling behind Go and JS implementations that already supported Gossipsub 2.0, exposing Python-based applications to:
How was it fixed?
This PR implements comprehensive Gossipsub 2.0 support by adding advanced peer scoring, adaptive gossip dissemination, enhanced security features, and improved message validation while maintaining full backward compatibility.
Summary of approach:
🔐 Enhanced Peer Scoring System
🌐 Adaptive Gossip Dissemination
🛡️ Security Enhancements
⚡ Enhanced Message Validation
🔄 Protocol Evolution
/meshsub/2.0.0protocol ID with full backward compatibilityKey Files Modified:
libp2p/pubsub/gossipsub.py: Core Gossipsub 2.0 implementationlibp2p/pubsub/score.py: Enhanced peer scoring with P6/P7 parameterslibp2p/pubsub/pubsub.py: Validation caching and timeout mechanismstests/core/pubsub/test_gossipsub_v2_0.py: Comprehensive v2.0 test suitetests/core/pubsub/test_validation_enhancements.py: Validation feature testsTo-Do
Benefits:
This implementation brings py-libp2p to feature parity with other libp2p language implementations and provides a robust foundation for production systems requiring reliable pubsub behavior.
Cute Animal Picture