Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a typescript types declaration file of libp2p/js-peer-id. #77

Closed
wants to merge 3 commits into from

Conversation

pboymt
Copy link

@pboymt pboymt commented Apr 25, 2018

I had test it, run well.

@dryajov
Copy link
Member

dryajov commented Apr 27, 2018

Thanks for the contribution!

However, I believe that this is probably better placed under the https://github.com/DefinitelyTyped/DefinitelyTyped. I would also suggest to take a look at the ipfs/js-ipfs#1260, where our flow effort is being undertaken. I believe that this might have a lot of overlap with that effort.

In any case, great job!

@daviddias
Copy link
Member

Thanks @pboymt. We have decided to move ahead with Flow (track: ipfs/js-ipfs#1260). Closing this one //cc @vmx

@daviddias daviddias closed this Jun 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants