feat: evaluate @roamhq/wrtc as alternative to node-datachannel #3356
+206
−163
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…p#3034) Replace node-datachannel with @roamhq/wrtc for WebRTC peer connections and stun package for STUN server functionality in WebRTC Direct. Changes: - Replace node-datachannel RTCPeerConnection with @roamhq/wrtc - Implement STUN server using stun package for WebRTC Direct - Remove DirectRTCPeerConnection wrapper class - Add extractRemoteFingerprint helper for SDP parsing - Remove node-datachannel-specific garbage collection workarounds - Add TypeScript definitions for stun package All unit tests pass (33 passing). WebRTC Direct functionality validated. Relates to libp2p#3034
This was referenced Nov 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3034
This PR evaluates @roamhq/wrtc as a replacement for node-datachannel as requested in #3034.
Implementation
Replaced node-datachannel with two focused libraries:
Changes
Test Results
Known Issue
Segmentation fault during test cleanup - Native module crash in @roamhq/wrtc destructor. All tests pass before crash occurs. Does not affect functionality, only test harness cleanup.
Stack trace shows crash in
RTCDataChannel::~RefPtr()andRTCPeerConnection::~RTCPeerConnection().