Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow specifying UPnP gateways and external address #2937

Merged
merged 1 commit into from
Feb 4, 2025

Conversation

achingbrain
Copy link
Member

Some ISP-provided routers are underpowered and require frequent reboots before they will respond to SSDP M-SEARCH messages.

To make working with them easier, allow manually specifying gateways and external network addresses.

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation if necessary (this includes comments as well)
  • I have added tests that prove my fix is effective or that my feature works

Some ISP-provided routers are underpowered and require frequent
reboots before they will respond to SSDP M-SEARCH messages.

To make working with them easier, allow manually specifying
gateways and external network addresses.
@achingbrain achingbrain requested a review from a team as a code owner February 4, 2025 09:45
@achingbrain achingbrain changed the title feat: allow specifying gateways and ports feat: allow specifying UPnP gateways and ports Feb 4, 2025
@achingbrain achingbrain changed the title feat: allow specifying UPnP gateways and ports feat: allow specifying UPnP gateways and external addresses Feb 4, 2025
@achingbrain achingbrain changed the title feat: allow specifying UPnP gateways and external addresses feat: allow specifying UPnP gateways and external address Feb 4, 2025
@achingbrain achingbrain merged commit 26313e6 into main Feb 4, 2025
35 checks passed
@achingbrain achingbrain deleted the feat/allow-specifying-gateways-and-ports branch February 4, 2025 10:15
@achingbrain achingbrain mentioned this pull request Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant