Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: remove outdated ping README #1910

Merged
merged 2 commits into from
Aug 1, 2023
Merged

Conversation

tabcat
Copy link
Contributor

@tabcat tabcat commented Jul 31, 2023

Closes #1590

Copy link
Member

@maschad maschad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know that there was suggestion to delete this but I think it may useful to have description (similar to identify) and for usage, have the API docs generated via our docs command.

cc @achingbrain

Copy link
Member

@maschad maschad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After discussing with @achingbrain it makes more sense to have this as a top-level doc with it's own subsection for describing the service, with the associated generated API docs.

@achingbrain achingbrain merged commit a2626b5 into libp2p:master Aug 1, 2023
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ping module has no method mount
3 participants