fix: remove closed listeners from transport manager #1733
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a listener closes, remove it from the stored list of listeners. This wasn't much of a problem before as listeners tended to be very long lived but circuit relay listeners get closed all the time so this fixes a memory leak.
Merged
maschad
reviewed
May 4, 2023
Member
maschad
left a comment
maschad
left a comment
There was a problem hiding this comment.
Left a comment, LGTM otherwise
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a listener closes, remove it from the stored list of listeners.
This wasn't much of a problem before as listeners tended to be very long lived but circuit relay listeners get closed all the time so this fixes a now much more obvious memory leak.