feat: add event bus #1693
Merged
feat: add event bus #1693
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds an event emitter as a libp2p component that will echo every emitted event on the main libp2p object. Fixes #1574
achingbrain
added a commit
to libp2p/js-libp2p-interfaces
that referenced
this pull request
Apr 16, 2023
Merged
achingbrain
added a commit
to libp2p/js-libp2p-interfaces
that referenced
this pull request
Apr 21, 2023
Removes events from some internal components and adds them to the event bus. Decouples internal components from each other since they can listen to the bus for events rather than having to know about the component that dispatches them. Refs: libp2p/js-libp2p#1693
Member
Author
|
Going to merge this to unblock #1563 - will address any PR comments in a follow up before |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an event emitter as a libp2p component that will echo every emitted event on the main libp2p object.
Closes #1574
Fixes #1630