This repository was archived by the owner on Feb 24, 2021. It is now read-only.
Fix/handshake error #101
Merged
Fix/handshake error #101
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Failed handshakes abort the connection but dont inform users of the failure properly. If a remote was not successfully negotiated this could cause a peerId missing issue
ghost
assigned
daviddias
approved these changes
Mar 28, 2018
There was a problem hiding this comment.
Excellent debugging! Thanks so much for fixing this @jacobheun :)
Did you manage to verify that indeed the js-ipfs daemon doesn't crash with this daemon anymore?
|
@diasdavid yes, I was able to run a daemon for the past two hours. It did end up crashing but it was due to ipfs/js-ipfs#1156. I leveraged @victorbjelkholm 's repo mentioned in the ipfs/js-ipfs#1221 description to reproduce and verify stability. I believe the root error occurs here, https://github.com/libp2p/js-libp2p-secio/blob/master/src/handshake/crypto.js#L74, as the remote id would not be set for the connection at this point, causing the ultimate peerId missing thrown error. |
This was referenced Jul 6, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Callback naming was inconsistent in some of the files so I cleaned those up to help make them easier to read and avoid any potential hoisting issues.
Errors in the handshake weren't being passed back to
finish, so if I handshake failed early enough that a peer id was not attained, it would cause an Assertion error attempting to set the peer info of the encrypted connection.fixes ipfs/js-ipfs#1221