This repository has been archived by the owner on Jul 21, 2023. It is now read-only.
fix _findNProvidersAsync discarding search results #137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacobheun
reviewed
Jul 24, 2019
There was a problem hiding this comment.
@Qmstream nice find! Would you mind adding a test for this? It would be great to avoid any future regressions of this, especially as we're migrating to full async/await code soon.
It looks like linting is failing due to extra white space on line 579.
kumavis
approved these changes
Jul 24, 2019
|
@jacobheun, I removed the dangling white space. But, sorry, I have no idea how I could write the suggested test (I have little experience with this). |
jacobheun
approved these changes
Jul 29, 2019
|
Thanks for looking to the PR and creating the issue @jacobheun |
|
Also @Qmstream thanks for this PR ❤️ |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
_findNProvidersAsynctimes out, it ignores the search results, as it's checking theoutarray before it's actually populated.